Repository navigation
fix(query): cap the arrow follow read at the row guard - #239
Merged
Merged
Conversation
Send limit = max_auto_rows + 1 when following a result as Arrow, so an oversized result is not downloaded only to be discarded.
eddietejeda
requested review from
anoop-narang
and removed request for
a team
November 19, 2026 19:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #238, from a review comment that arrived as it merged.
When
query_arrowfollows a large result, the row guard stopped the read but the connection drain still downloaded the rest of the body. The read now asks for at mostmax_auto_rows + 1rows: enough to detect the overflow, nothing more. No limit is sent when the guard isNone.No changelog entry:
query_arrowis unreleased and already listed.