Skip to content

fix(query): cap the arrow follow read at the row guard - #239

Merged
eddietejeda merged 1 commit into
mainfrom
fix/query-arrow-follow-limit
Nov 19, 2026
Merged

eddietejeda merged 1 commit into
mainfrom
fix/query-arrow-follow-limit

Conversation

@eddietejeda

Copy link
Copy Markdown
Contributor

Follow-up to #238, from a review comment that arrived as it merged.

When query_arrow follows a large result, the row guard stopped the read but the connection drain still downloaded the rest of the body. The read now asks for at most max_auto_rows + 1 rows: enough to detect the overflow, nothing more. No limit is sent when the guard is None.

No changelog entry: query_arrow is unreleased and already listed.

Send limit = max_auto_rows + 1 when following a result as Arrow, so an
oversized result is not downloaded only to be discarded.
@eddietejeda
eddietejeda requested a review from a team as a code owner November 19, 2026 19:12
@eddietejeda
eddietejeda requested review from anoop-narang and removed request for a team November 19, 2026 19:12
@eddietejeda
eddietejeda merged commit 9845af4 into main Nov 19, 2026
6 of 7 checks passed
@eddietejeda
eddietejeda deleted the fix/query-arrow-follow-limit branch November 19, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant